Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two failing e2e tests #4380

Merged
merged 2 commits into from
May 9, 2024
Merged

fix two failing e2e tests #4380

merged 2 commits into from
May 9, 2024

Conversation

sashankaryal
Copy link
Contributor

@sashankaryal sashankaryal commented May 9, 2024

Summary by CodeRabbit

  • New Features

    • Added drag functionality to the 3D assets panel.
    • Introduced data-cy attributes for better testability of UI components.
    • New method to update asset paths in 3D scenes based on provided mappings.
  • Documentation

    • Updated plugin documentation descriptions and added new plugin information.
  • Style

    • Minor style adjustment in the ViewBar component for better icon alignment.
  • Bug Fixes

    • Improved timezone handling in data processing to ensure accurate date conversions.
    • Enhanced tracking method in video processing for better accuracy and error handling.
  • Tests

    • Added new test cases for 3D media handling and date field manipulations in datasets.

@sashankaryal sashankaryal requested a review from benjaminpkane May 9, 2024 16:44
@sashankaryal sashankaryal changed the base branch from develop to release/v0.24.0 May 9, 2024 16:44
Copy link
Contributor

coderabbitai bot commented May 9, 2024

Walkthrough

This update introduces a variety of enhancements across multiple components, focusing on UI improvements, data handling, and testing enhancements. Notable changes include the addition of attributes for better test automation, updates to asset path handling in 3D scenes, and refinements in date and timezone processing. Overall, these modifications aim to improve functionality, streamline testing processes, and enhance user and developer experience.

Changes

Files Change Summary
.../ViewBar.tsx, .../Leva.tsx Added style and data attributes for UI components.
.../index.rst Updated plugin descriptions and added new entries.
.../assets-panel/index.ts, .../specs/... Introduced new class and methods for handling 3D assets and updated test specifications.
.../fields.py, .../odm/database.py, .../threed/scene_3d.py, .../data/exporters.py Enhanced data handling and timezone adjustments, updated asset path management in 3D scenes.
.../tracking/deepsort.py, .../dataset_tests.py, .../import_export_tests.py Refactored tracking method, added new testing classes and methods, improved import/export tests.

🐰✨
Code hops and leaps, changes abound,
From fields to forms, improvements are found.
With each line tweaked, a new feature springs,
In digital meadows, where data sings.
Cheers to the devs, with minds so bright,
Crafting a world of code, byte by byte!
🌼🌿


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sashankaryal sashankaryal self-assigned this May 9, 2024
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@sashankaryal sashankaryal merged commit 3de1338 into release/v0.24.0 May 9, 2024
16 checks passed
@sashankaryal sashankaryal deleted the fix/e2e branch May 9, 2024 18:51
benjaminpkane pushed a commit that referenced this pull request May 20, 2024
* fix multi pcd e2e

* fix media visibility toggler e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants