Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #3815 remove cvat filename prefixing #3823

Merged

Conversation

hoshimura
Copy link
Contributor

@hoshimura hoshimura commented Nov 20, 2023

Resolves #3815

keeping old behavior for cvat versions < 2.4.6 because of cvat bug fix cvat-ai/cvat#5083

Change-Id: I542695437c05c09bb48023d598af479965abb384

What changes are proposed in this pull request?

For cvat server versions >= 2.4.6

  • remove the sequence prefix added to maintain the lexographical order of older cvat versions.

How is this patch tested? If it is not, please explain why.

Verified on our local cvat instance before and after patch

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

Solves issue #3815 addressing filename prefixing of cvat samples.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@brimoor brimoor requested a review from ehofesmann November 20, 2023 16:31
@brimoor brimoor added the enhancement Code enhancement label Nov 20, 2023
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoshimura amazing thank you!

@ehofesmann can you give this a quick review + test?

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.23.0@57c4524). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.23.0    #3823   +/-   ##
==================================================
  Coverage                   ?   15.65%           
==================================================
  Files                      ?      728           
  Lines                      ?    80536           
  Branches                   ?     1074           
==================================================
  Hits                       ?    12609           
  Misses                     ?    67927           
  Partials                   ?        0           
Flag Coverage Δ
app 15.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

keeping old behavior for cvat versions < 2.4.6 because
of cvat bug fix cvat-ai/cvat#5083

Change-Id: I542695437c05c09bb48023d598af479965abb384
@hoshimura hoshimura force-pushed the remove_cvat_number_prefixing branch from 387e769 to 82a157f Compare November 21, 2023 10:55
@brimoor brimoor changed the base branch from develop to release/v0.23.0 November 28, 2023 17:20
Copy link
Member

@ehofesmann ehofesmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @hoshimura ! This is something I've been wanting to take a look at for some time, this update is much appreciated. It works great!

@ehofesmann ehofesmann merged commit 260378a into voxel51:release/v0.23.0 Nov 28, 2023
8 of 9 checks passed
@hoshimura hoshimura deleted the remove_cvat_number_prefixing branch November 29, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants