Enhancements to ODM migration #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylerganter added more stuff to this PR. See changelog |
tylerganter
reviewed
May 6, 2020
tylerganter
reviewed
May 6, 2020
tylerganter
reviewed
May 6, 2020
tylerganter
reviewed
May 6, 2020
| @property | ||
| def name(self): | ||
| return self._name | ||
| if not create_empty and not self: |
There was a problem hiding this comment.
what does not self mean here?
There was a problem hiding this comment.
Ah, I understand what it means now, missed the definition of __bool__. But I suppose we have a minor issue that creating an empty dataset is meaningless. It does nothing on the backend ATM. So we may need some way of tracking that in the future. I would just mark it as a todo and move on
There was a problem hiding this comment.
Yeah I noted that. We can move on for now
tylerganter
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log
BackedByDocumentsubclasses now explicitly implement theircreate_new()methods and callBackedByDocument._create_new()to construct the underlyingODMDocuments. The reason for this is documentation:Sample.create_new()needs to exist so that the meaning of all of the relevant fields can be clearly documented for the user to understand what's going on. The previous implementation withget_odm_kwargs()was hiding all of that. Also, it's a good practice to avoid constructing dictionaries of parameters in code. Dictionaries are magic things that can contain anything. It's better to pass keyword arguments around as keyword arguments, so your IDE/linter/static analyzer can tell what's happening and warn if a particular parameter is not validDataset.add_samples(). IDK if this is efficient or not, but it does workfiftyone.core.labels.Labelclasses to use new interface. This includes addingODMDocumentclasses to back these constructs in the DBSample.add_label()Miscellaneous