Skip to content

Commit

Permalink
updating tests
Browse files Browse the repository at this point in the history
  • Loading branch information
brimoor committed Nov 23, 2024
1 parent 5ad59de commit 4e0a5bb
Showing 1 changed file with 1 addition and 31 deletions.
32 changes: 1 addition & 31 deletions tests/unittests/operators/delegated_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def test_delegate_operation(
self.assertIsNotNone(doc.queued_at)
self.assertEqual(doc.label, "Mock Operator")
self.assertEqual(doc.run_state, ExecutionRunState.QUEUED)
self.assertIsNone(doc.metadata)
self.assertEqual(doc.metadata, {})

doc2_metadata = {"inputs_schema": {}}
doc2 = self.svc.queue_operation(
Expand All @@ -227,7 +227,6 @@ def test_delegate_operation(
self.assertIsNotNone(doc2.queued_at)
self.assertEqual(doc2.label, "@voxelfiftyone/operator/foo")
self.assertEqual(doc2.run_state, ExecutionRunState.QUEUED)
self.assertIsNotNone(doc2.metadata)
self.assertEqual(doc2.metadata, doc2_metadata)

def test_list_operations(self, mock_get_operator, mock_operator_exists):
Expand Down Expand Up @@ -485,35 +484,6 @@ def test_sets_progress(
self.assertEqual(doc.status.label, "halfway there")
self.assertIsNotNone(doc.status.updated_at)

def test_output_schema_null_metadata(
self, mock_get_operator, mock_operator_exists
):
mock_outputs = MockOutputs()
doc = self.svc.queue_operation(
operator="@voxelfiftyone/operator/foo",
delegation_target="test_target",
context=ExecutionContext(request_params={"foo": "bar"}),
)

# Set metadata to null instead of being unset, to test that corner case
self.svc._repo._collection.find_one_and_update(
{"_id": bson.ObjectId(doc.id)}, {"$set": {"metadata": None}}
)

self.svc.set_completed(
doc.id,
result=ExecutionResult(outputs_schema=mock_outputs.to_json()),
)

doc = self.svc.get(doc_id=doc.id)
self.assertEqual(doc.run_state, ExecutionRunState.COMPLETED)
self.assertEqual(
doc.metadata,
{
"outputs_schema": mock_outputs.to_json(),
},
)

@patch(
"fiftyone.core.odm.utils.load_dataset",
)
Expand Down

0 comments on commit 4e0a5bb

Please sign in to comment.