add flags that allow both pcd and ply geometries to be centered (#4843)

* center geometry by default for ply and not for pcd

* add docs

app/packages/looker-3d/src/fo3d/mesh/Ply.tsx

@@ -124,7 +124,13 @@ const PlyWithNoMaterialOverride = ({
 
 export const Ply = ({
   name,
-  ply: { plyPath, preTransformedPlyPath, defaultMaterial, isPcd },
+  ply: {
+    plyPath,
+    preTransformedPlyPath,
+    defaultMaterial,
+    isPcd,
+    centerGeometry,
+  },
   position,
   quaternion,
   scale,
@@ -161,15 +167,18 @@ export const Ply = ({
       !geometry.attributes.normal?.count
     ) {
       geometry.computeVertexNormals();
-      geometry.center();
+
+      if (centerGeometry) {
+        geometry.center();
+      }
     }
 
     if (geometry.attributes?.color?.count) {
       setIsUsingVertexColors(true);
     }
 
     setIsGeometryResolved(true);
-  }, [geometry]);
+  }, [geometry, centerGeometry]);
 
   const mesh = useMemo(() => {
     if (!isGeometryResolved) {

app/packages/looker-3d/src/fo3d/point-cloud/Pcd.tsx

@@ -10,7 +10,7 @@ import { usePcdMaterial } from "./use-pcd-material";
 
 export const Pcd = ({
   name,
-  pcd: { pcdPath, preTransformedPcdPath, defaultMaterial },
+  pcd: { pcdPath, preTransformedPcdPath, defaultMaterial, centerGeometry },
   position,
   quaternion,
   scale,
@@ -37,12 +37,11 @@ export const Pcd = ({
   // todo: hack until https://github.com/pmndrs/react-three-fiber/issues/245 is fixed
   const points = useMemo(() => points_.clone(false), [points_]);
 
-  // todo: expose centering of points as an opt-in behavior from the sdk
-  // useEffect(() => {
-  //   if (points) {
-  //     points.geometry.center();
-  //   }
-  // }, [points]);
+  useEffect(() => {
+    if (points && centerGeometry) {
+      points.geometry.center();
+    }
+  }, [points, centerGeometry]);
 
   const pcdContainerRef = useRef();
 

app/packages/looker-3d/src/hooks/use-fo3d.ts

@@ -94,7 +94,8 @@ export class PcdAsset {
   constructor(
     readonly pcdPath?: string,
     readonly preTransformedPcdPath?: string,
-    readonly defaultMaterial?: FoPointcloudMaterialProps
+    readonly defaultMaterial?: FoPointcloudMaterialProps,
+    readonly centerGeometry?: boolean
   ) {}
 }
 
@@ -103,7 +104,8 @@ export class PlyAsset {
     readonly plyPath?: string,
     readonly preTransformedPlyPath?: string,
     readonly defaultMaterial?: FoMeshMaterial,
-    readonly isPcd?: boolean
+    readonly isPcd?: boolean,
+    readonly centerGeometry?: boolean
   ) {}
 }
 
@@ -306,7 +308,8 @@ export const useFo3d = (
               node["plyPath"],
               node["preTransformedPlyPath"],
               material as FoMeshMaterial,
-              node["isPointCloud"] ?? false
+              node["isPointCloud"] ?? false,
+              node["centerGeometry"] ?? true
             );
           }
         }
@@ -315,7 +318,8 @@ export const useFo3d = (
           asset = new PcdAsset(
             node["pcdPath"],
             node["preTransformedPcdPath"],
-            material as FoPointcloudMaterialProps
+            material as FoPointcloudMaterialProps,
+            node["centerGeometry"] ?? false
           );
         }
       } else if (node["_type"].endsWith("Geometry")) {

fiftyone/core/threed/mesh.py

@@ -269,6 +269,8 @@ class PlyMesh(Mesh):
             absolute or relative to the directory containing the ``.fo3d`` file
         is_point_cloud (bool): whether the PLY file is a point cloud. Defaults
             to ``False``
+        center_geometry (bool): whether to center the geometry. Defaults to
+            ``True``
         material (:class:`fiftyone.core.threed.MeshMaterial`, optional):
             default material for the mesh if PLY file does not contain
             vertex colors. Defaults to
@@ -291,6 +293,7 @@ def __init__(
         name: str,
         ply_path: str,
         is_point_cloud: bool = False,
+        center_geometry: bool = True,
         default_material: Optional[MeshMaterial] = None,
         visible=True,
         position: Optional[Vec3UnionType] = None,
@@ -309,13 +312,18 @@ def __init__(
         if not ply_path.lower().endswith(".ply"):
             raise ValueError("PLY mesh must be a .ply file")
 
+        self.center_geometry = center_geometry
         self.ply_path = ply_path
         self.is_point_cloud = is_point_cloud
 
     def _to_dict_extra(self):
         r = {
             **super()._to_dict_extra(),
-            **{"plyPath": self.ply_path, "isPointCloud": self.is_point_cloud},
+            **{
+                "centerGeometry": self.center_geometry,
+                "plyPath": self.ply_path,
+                "isPointCloud": self.is_point_cloud,
+            },
         }
 
         if hasattr(self, "_pre_transformed_ply_path"):

fiftyone/core/threed/pointcloud.py

@@ -24,6 +24,8 @@ class PointCloud(Object3D):
             the material of the point cloud. If not specified, defaults to a
             new instance of :class:`fiftyone.core.threed.PointCloudMaterial`
             with its default parameters
+        center_geometry (bool): whether to center the geometry of the point
+            cloud. Defaults to ``False``
         flag_for_projection (bool): whether to flag the point cloud for
             usage in orthographic projection. Each
             :class:`fiftyone.core.threed.Scene` can have at most one asset
@@ -45,6 +47,7 @@ def __init__(
         name: str,
         pcd_path: str,
         material: Optional[PointCloudMaterial] = None,
+        center_geometry: bool = False,
         flag_for_projection: bool = False,
         visible=True,
         position: Optional[Vec3UnionType] = None,
@@ -67,6 +70,7 @@ def __init__(
         if isinstance(material, dict):
             material = PointCloudMaterial._from_dict(material)
 
+        self.center_geometry = center_geometry
         self.default_material = material or PointCloudMaterial()
         self.flag_for_projection = flag_for_projection
 
@@ -84,6 +88,7 @@ def set_default_material(self, material: PointCloudMaterial):
     def _to_dict_extra(self):
         """Extra properties to include in dictionary representation."""
         r = {
+            "centerGeometry": self.center_geometry,
             "pcdPath": self.pcd_path,
             "defaultMaterial": self.default_material.as_dict(),
             "flagForProjection": self.flag_for_projection,