Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it is time to deprecate python 3.8 #193

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

findtopher
Copy link
Member

What changes are proposed in this pull request?

Deprecate python 3.8 as as foretold by prophecy

@findtopher findtopher requested review from benjaminpkane and brimoor and removed request for benjaminpkane September 19, 2024 14:30
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we trying to kill off 3.8 in fiftyone==1.0?

@findtopher
Copy link
Member Author

Are we trying to kill off 3.8 in fiftyone==1.0?

Yes, like we said we would over on the deprecation page

@findtopher
Copy link
Member Author

it looks like I need this PR merged before the tests in fiftyone-brain will work

@findtopher findtopher requested a review from brimoor September 19, 2024 20:58
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@findtopher findtopher merged commit 88405d4 into develop Sep 24, 2024
5 checks passed
@findtopher findtopher deleted the topher/deprecate-python-8 branch September 24, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants