Upgrades to support remote zoo models #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swheaton
reviewed
Sep 10, 2024
| models = [] | ||
|
|
||
| if name is not None: | ||
| subdir = os.path.join(*name.split("/")) |
There was a problem hiding this comment.
This seems like it is a no-op? You're splitting then joining it back together again. Do you mean to take out the file name? If so, why not use os.path.dirname(name)?
There was a problem hiding this comment.
It's for windows. Converting org-name/model-name to org-name\model-name if necessary
There was a problem hiding this comment.
mm I see. A little confusing that name is assigned to subdir then.
swheaton
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting PR for voxel51/fiftyone#4786