Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a step to CI that validates the installer checksum #1872

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add a step to CI that validates the installer checksum #1872

merged 1 commit into from
Aug 23, 2024

Conversation

charlespierce
Copy link
Contributor

@charlespierce charlespierce commented Aug 23, 2024 •
edited
Loading

Info

  • Noted in fix: update checksum for unix install script #1861, we need to update the SHASUMS256.txt file for the installer script whenever we make changes to the installer.
  • This adds a simple CI check that verifies the checksum to run on PRs, so that we can't forget to update the hash.

Changes

  • Added a new CI job that validates the checksum

Tested

  • Tested in this PR that the job passes when there are no changes to volta-install.sh and fails when there are changes that don't also update the SHASUMS256.txt file.

@charlespierce charlespierce force-pushed the validate_installer_checksum branch 2 times, most recently from 9991dec to bd086a1 Compare August 23, 2024 19:57
chriskrycho
chriskrycho approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chriskrycho chriskrycho merged commit c690778 into volta-cli:main Aug 23, 2024
26 checks passed
@charlespierce charlespierce deleted the validate_installer_checksum branch August 23, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlespierce @chriskrycho