add --target-bin-dir to execute #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the most important part of #207, everything else is bonus. |
volks73
requested changes
Aug 31, 2023
102e8ef to
f4de9b3
Compare
This sets CargoTargetBinDir in the wix template, allowing something orchestrating cargo-wix to take the reigns on building/gathering binaries completely. Setting this an --no-build supresses the warning (as at this point there's a pretty clear signal the user is doing this intentionally and not as a temp thing). No integration tests were added for this functionality because it wasn't clear to me how to reasonable test this, but the functionality is boring enough that it's easy to trust. As compensation some backlog tests/docs were added. ----- Also does some cleanups to factor target-triple/profile logic so that things aren't recomputed in a bunch of places. Also adds the arguably-forgotten-to-be-added package.metadata.wix.profile (for projects that always want to build with a special profile). Note that --target-bin-dir this time is *intentionally* without a package.metadata pair, because it's pretty exceptional to want to fully bake the target dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets CargoTargetBinDir in the wix template, allowing something orchestrating cargo-wix to take the reigns on building/gathering binaries completely. Setting this an --no-build supresses the warning (as at this point there's a pretty clear signal the user is doing this intentionally and not as a temp thing).
No integration tests were added for this functionality because it wasn't clear to me how to reasonable test this, but the functionality is boring enough that it's easy to trust with just the unit tests.
As compensation some backlog tests/docs were added.
Also does some cleanups to factor target-triple/profile logic so that things aren't recomputed in a bunch of places.
Also adds the arguably-forgotten-to-be-added package.metadata.wix.profile (for projects that always want to build with a special profile).
Note that --target-bin-dir this time is intentionally without a package.metadata pair, because it's pretty exceptional to want to fully bake the target dir.