Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs CI: switch to linkinator #335

Merged
merged 3 commits into from
Apr 30, 2023
Merged

Docs CI: switch to linkinator #335

merged 3 commits into from
Apr 30, 2023

Conversation

mbackenkoehler
Copy link
Collaborator

@mbackenkoehler mbackenkoehler commented Apr 26, 2023

Description

Switch from broken-link-checker to linkinator. The former seems to be dead.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Check all dead links

Questions

  • What's the reasoning behind the excludes?

Status

  • Ready to go

@mbackenkoehler mbackenkoehler linked an issue Apr 26, 2023 that may be closed by this pull request
@mbackenkoehler
Copy link
Collaborator Author

Merging this will resolve #333

There are a lot of dead links around, which need to be fixed manually. I will open a separate issue for that.

@dominiquesydow
Copy link
Collaborator

Hi @mbackenkoehler, thanks a lot for this update - ready to go from my side.

Copy link
Collaborator

@dominiquesydow dominiquesydow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mbackenkoehler,
As there are a couple of PRs that depend on each other in order to get the CI pass, could you please branch off master something like ci-fixes-base and then merge all the open PRs to that branch first?
Basically, so that we see the full CI pass before merging everything to master. @AndreaVolkamer, please do intervene if you'd like to go ahead in another way.

@AndreaVolkamer
Copy link
Member

@dominiquesydow thanks that is a good idea, @mbackenkoehler can you coordinate this?

@mbackenkoehler
Copy link
Collaborator Author

Hi @mbackenkoehler, As there are a couple of PRs that depend on each other in order to get the CI pass, could you please branch off master something like ci-fixes-base and then merge all the open PRs to that branch first? Basically, so that we see the full CI pass before merging everything to master. @AndreaVolkamer, please do intervene if you'd like to go ahead in another way.

Maybe we should use a general dev branch for that. Since there are also some non-CI issues that should be done and merged simoultaneously. @dominiquesydow Do we want to use the existing dev branch?

@dominiquesydow
Copy link
Collaborator

dominiquesydow commented Apr 28, 2023 via email

@mbackenkoehler mbackenkoehler mentioned this pull request Apr 30, 2023
@mbackenkoehler mbackenkoehler changed the base branch from master to dev April 30, 2023 14:49
@mbackenkoehler mbackenkoehler merged commit e788c5d into dev Apr 30, 2023
@mbackenkoehler mbackenkoehler deleted the 333-docs-ci-fails branch May 1, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs CI fails
3 participants