-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs CI: switch to linkinator #335
Conversation
Merging this will resolve #333 There are a lot of dead links around, which need to be fixed manually. I will open a separate issue for that. |
Hi @mbackenkoehler, thanks a lot for this update - ready to go from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mbackenkoehler,
As there are a couple of PRs that depend on each other in order to get the CI pass, could you please branch off master
something like ci-fixes-base
and then merge all the open PRs to that branch first?
Basically, so that we see the full CI pass before merging everything to master
. @AndreaVolkamer, please do intervene if you'd like to go ahead in another way.
@dominiquesydow thanks that is a good idea, @mbackenkoehler can you coordinate this? |
Maybe we should use a general dev branch for that. Since there are also some non-CI issues that should be done and merged simoultaneously. @dominiquesydow Do we want to use the existing |
Good idea!
…On Fri 28. Apr 2023 at 13:12, Michael Backenköhler ***@***.***> wrote:
Hi @mbackenkoehler <https://github.com/mbackenkoehler>, As there are a
couple of PRs that depend on each other in order to get the CI pass, could
you please branch off master something like ci-fixes-base and then merge
all the open PRs to that branch first? Basically, so that we see the full
CI pass before merging everything to master. @AndreaVolkamer
<https://github.com/AndreaVolkamer>, please do intervene if you'd like to
go ahead in another way.
Maybe we should use a general dev branch for that. Since there are also
some non-CI issues that should be done and merged simoultaneously.
@dominiquesydow <https://github.com/dominiquesydow> Do we want to use the
existing dev branch?
—
Reply to this email directly, view it on GitHub
<#335 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABW7RNP5C7V6LHBDGJYSVZ3XDOXZJANCNFSM6AAAAAAXMD3NAE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
Switch from
broken-link-checker
tolinkinator
. The former seems to be dead.Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status