Consistently represent dbg #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The breakpoint extension instruction is written as `debugger` for the assembler, but printed as `dbg` by the debugger and internally named `dbg`. This difference makes the output of the disassembler not able to be fed into the assembler. Settle on `dbg` to match the other short names.
It enables not only the `dbg` instruction, but also bitwise operations, so broaden the name.
The parser accepts both "\n\n " and "\n\n\t" for dbg, but the assembler always emits "\n\n ". Accept only the former. Also, similarly refactor the stack opcode parsing to simplify.
The `test` shorthand from Burghard wsa is not supported by the assembler.
`String.prototype.split` and `String.prototype.charCodeAt` separate Unicode codepoints into UTF-16 code units.
voliva
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
This is awesome, I truly appreciate this @thaliaarchi! This is something I wanted to address too.
Thank you so much!
Offtopic, but I think you might find interesting that I have successfully implemented keccak-256 hashing function, published here
|
I saw when you added keccac.wsa. Quite impressive! I like the decorator feature you added too. (By the way, when there's more decorators than compiled lines, the trailing decorators are dropped. I'm not sure how that should be handled.) You may be interested to know that I'm working on a language server for Whitespace assembly (including your dialect). I can't promise when it'll be ready, but I'm excited since I've been intending to do this for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
dbginstruction more consistent. The assembler recognized it as bothdebugger, but it wasdbgelsewhere, and the Whitespace parser recognized it as both"\n\n "and"\n\n\t", but the assembler always emitted"\n\n ". Standardize ondbgand"\n\n ".Also rename the
--debuggeroption to--extensionsto reflect its broader purpose and fix a broken test.See the commit messages for more details.
I'm revisiting my universal assembler, so these fixes came to mind. You may be interested in seeing my list of extension instructions from various Whitespace implementations, including yours.