Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add support for tools call #379

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BearBiscuit05
Copy link
Contributor

Add support for tools call #344.

@BearBiscuit05
Copy link
Contributor Author

BearBiscuit05 commented Feb 25, 2025

An immature implementation has been completed using main_generation for initial testing. Currently, there are several design issues that need to be addressed:

  1. The placement of the tool parameter is unclear.
  2. When using chat to eventually call the generate_sequences function, should we create a new function for chat or directly reuse generate_sequences and use parameters to switch between self.rollout.chat and self.rollout.generate_sequences?
  3. It’s uncertain whether the way the chat function is structured in the rollout class is concise enough.

In summary, I might need more time to streamline the params and gain a deeper understanding of verl. This will likely take some time. And I would appreciate some advice on this.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants