Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remote Reward Server Feature #329

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

YuchenFan48
Copy link

Description

This PR introduces support for remote generative models to enhance the verification and reward assignment process in VERL. Previously, VERL only supported rule-based rewards for verification. With this update, we enable more flexible and dynamic reward mechanisms using generative models.

Key Changes

  1. Bug Fix:

    • Resolved an issue in main_ppo.py where the val_dataloader was incorrectly processed in batches. This ensures proper handling of validation data during training.
  2. New Features:

    • Added a Generative Reward Manager in workers/reward_manager to handle reward generation using remote generative models.
    • Implemented a corresponding compute_score function in utils/reward_score to calculate scores based on generative model outputs.
  3. Issue Resolution:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have an empty file here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved the empty file problem

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File removed

run_ppo.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, file removed already

@@ -0,0 +1,163 @@
import re
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a license similar to other files. Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licence Added.

@@ -0,0 +1,89 @@
import asyncio
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a license similar to other files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License added.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2025

CLA assistant check
All committers have signed the CLA.

@YuchenFan48
Copy link
Author

CLA signed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reward model on a remote server
4 participants