Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control the number of feasible nodes to find and score in scheduling #491

Merged
merged 12 commits into from
Oct 30, 2019
Merged

Control the number of feasible nodes to find and score in scheduling #491

merged 12 commits into from
Oct 30, 2019

Conversation

yuanchen8911
Copy link
Contributor

Added a new feature that allows the scheduler to stop looking for more feasible nodes once it finds a certain number of them. The idea is described in the official document https://kubernetes.io/docs/concepts/scheduling/scheduler-perf-tuning/.

The implementation is similar to the K8S official scheduler https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/core/generic_scheduler.go

The number of feasible nodes is determined by the following parameters.

  • MinNodesToFind specifies the minimum number of feasible nodes to find. The default value is 100.
  • PercentageOfNodesToFind specifies the percentage of feasible nodes to find. The default value is 100%. If the value is less than or equal to zero, an adaptive percentage is calculated according to a simple formula.
  • MinPercentageOfNodesToFind specifies the minimum percentage of feasible nodes to find. The default value is 5%. It ensures that the calculated adaptive percentage is not too small.

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @yuanchen8911,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 1eb81200-f9b4-11e9-93c5-f3e7c8487984

k82cn
k82cn reviewed Oct 29, 2019
View reviewed changes
cmd/scheduler/app/options/options.go Outdated
@@ -33,6 +33,11 @@ const (

defaultQPS = 50.0
defaultBurst = 100

// Default arameters to control the number of feasible nodes to find and score
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/arameters/parameters ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the errors. make verify and unit-test passed. Thanks.

@k82cn
Copy link
Member

k82cn commented Oct 29, 2019

/approve

LGTM overall, would you help to fix ci issue? We can get this merged when CI is happy :)

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, yuanchen8911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@TravisBuddy
Copy link

Hey @yuanchen8911,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 04a5f9b0-fa98-11e9-9401-ff5cf87227ee

@k82cn
Copy link
Member

k82cn commented Oct 30, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@k82cn
Copy link
Member

k82cn commented Oct 30, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@TravisBuddy
Copy link

Hey @yuanchen8911,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 1c0088e0-fac1-11e9-94bd-fbbf6873bcfd

@TravisBuddy
Copy link

Hey @yuanchen8911,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 76506de0-fac3-11e9-94bd-fbbf6873bcfd

@volcano-sh-bot volcano-sh-bot merged commit f398043 into volcano-sh:master Oct 30, 2019
@yuanchen8911 yuanchen8911 mentioned this pull request Apr 22, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuanchen8911 @TravisBuddy @k82cn @volcano-sh-bot