Merge pull request #167 from SrinivasChilveri/ttlvalidation

Added ttl validation in admission controller

pkg/admission/admit_job.go

@@ -86,6 +86,11 @@ func validateJob(job v1alpha1.Job, reviewResponse *v1beta1.AdmissionResponse) st
 		return fmt.Sprintf("'maxRetry' cannot be less than zero.")
 	}
 
+	if job.Spec.TTLSecondsAfterFinished != nil && *job.Spec.TTLSecondsAfterFinished < 0 {
+		reviewResponse.Allowed = false
+		return fmt.Sprintf("'ttlSecondsAfterFinished' cannot be less than zero.")
+	}
+
 	if len(job.Spec.Tasks) == 0 {
 		reviewResponse.Allowed = false
 		return fmt.Sprintf("No task specified in job spec")

test/e2e/admission.go

@@ -180,4 +180,34 @@ var _ = Describe("Job E2E Test: Test Admission service", func() {
 		Expect(createdJob.Spec.Queue).Should(Equal("default"),
 			"Job queue attribute would default to 'default' ")
 	})
+
+	It("ttl illegal", func() {
+		jobName := "job-ttl-illegal"
+		namespace := "test"
+		var ttl int32
+		ttl = -1
+		context := initTestContext()
+		defer cleanupTestContext(context)
+
+		_, err := createJobInner(context, &jobSpec{
+			min:       1,
+			namespace: namespace,
+			name:      jobName,
+			ttl:       &ttl,
+			tasks: []taskSpec{
+				{
+					img:  defaultNginxImage,
+					req:  oneCPU,
+					min:  1,
+					rep:  1,
+					name: "taskname",
+				},
+			},
+		})
+		Expect(err).To(HaveOccurred())
+		stError, ok := err.(*errors.StatusError)
+		Expect(ok).To(Equal(true))
+		Expect(stError.ErrStatus.Code).To(Equal(int32(500)))
+		Expect(stError.ErrStatus.Message).To(ContainSubstring("'ttlSecondsAfterFinished' cannot be less than zero."))
+	})
 })