fix: modify regex to enforce key name of "version"

[nkirkes]

Currently, regex will match anything with "version" in the key name. When tracking more than one version scheme, such as "apiVersion", and if that additional scheme is the first occurrence the regex finds, the bump will be applied to that key:value.

Change to regex removes the ? modifier for quotes which A) enforces proper JSON format and B) restricts key name for the bump target to "version" (still case insensitive).

[nkirkes]

I should note, in my case, this was relevant in a config.json file I wanted to bump along with the package.json. In my config.json, I'm tracking several version numbers for different APIs/uses, but have one "version" that I wanted to bump. grunt-bump was updating only the first occurrence the regex hit, which was an incorrect target, potentially causing other versioning problems.

Maybe a better way to mitigate this is by allowing a custom defined key name in the bump options, defaulting to "version" if one is not defined.

[eddiemonge]

I like your second suggestion about the custom defined key.

• Sample json files to test this change against
• Commit message doesn't follow guidelines

[eddiemonge]

ping @nkirkes

[eddiemonge]

I wonder if it would be better to only require JSON files and then parse it as JSON and get the root version key that way.

[nkirkes]

That would make it easier, yes. Are you still thinking that the root version key would be defined as an option (defaulting to "version")?

[eddiemonge]

possibly yes. Im not sure about specifying a key to use though

[nkirkes]

Hmm.. Let me think on that. If you don't mind, I'll take a crack at implementing this.

[skobkin]

Had the same problem: #113.

[eddiemonge]

Closing as this isn't the best fix. See #119 for more info