-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
olm: update to 3.0.0 #7151
olm: update to 3.0.0 #7151
Conversation
Please test the python bindings, the removed patch is meant to fix the python bindings. |
make test : |
On Mon, Jan 14, 2019 at 08:41:42PM -0800, Nathan wrote:
> Please test the python bindings, the removed patch is meant to fix the python bindings.
make test :
https://termbin.com/875h
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#7151 (comment)
Sounds fine-ish, please check if you can import the olm bindings
|
Probably someone will have to check that part, I don't know much about programming if any really :\ |
install it, start python and try to import the python module |
It doesn’t have that file to patch anymore but I MIGHT know how to fix it Edit: seems the library _libolm isn’t being built |
Going to contact upstream and see what can be done |
@maxice8 This worked for me, no import error(tested python3) |
maintainer="Adam Beckmeyer <adam_gpg@thebeckmeyers.xyz>" | ||
license="Apache-2.0" | ||
homepage="https://git.matrix.org/git/olm/about/" | ||
distfiles="https://git.matrix.org/git/olm/snapshot/${pkgname}-${version}.tar.gz" | ||
checksum=533714fb84860e04c185790d16ef9085f15e902c2105db941d5c7e92b0565ef8 | ||
checksum=4c54f93e4f426a9d5c8e66e63113d42fd2afca240cdcff30a469a342a6ec3bc6 | ||
nocross=yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why mark it nocross? It was possible to cross-compile before, the package is in the aarch64 repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the install stage it uses the host gcc instead of target’s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An it isn't possible to find a way around that or patch it to do the right thing? Adding nocross to new packages that simply cannot be crosscompiled is one thing but setting existing packages nocross means the repositories have to be cleaned up manually and people already using a package on cross-compiled architectures will loose functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try more, as I was trying to avoid setting nocross
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After digging more into it, seems it is CFFI causing issues
I can not fix cross-compile, no matter if I try to override LD, something with cffi uses host's ld |
matrix-org/olm#16 This is the bug report, so hopefully it will be fixed in the future, so this package can be updated to be cross-friendly |
No description provided.