Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olm: update to 3.0.0 #7151

Closed
wants to merge 1 commit into from
Closed

olm: update to 3.0.0 #7151

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Jan 15, 2019

No description provided.

@maxice8
Copy link
Contributor

maxice8 commented Jan 15, 2019

Please test the python bindings, the removed patch is meant to fix the python bindings.

@ndowens
Copy link
Contributor Author

ndowens commented Jan 15, 2019

Please test the python bindings, the removed patch is meant to fix the python bindings.

make test :
https://termbin.com/875h

@maxice8
Copy link
Contributor

maxice8 commented Jan 15, 2019 via email

@ndowens
Copy link
Contributor Author

ndowens commented Jan 15, 2019

Probably someone will have to check that part, I don't know much about programming if any really :\

@maxice8
Copy link
Contributor

maxice8 commented Jan 15, 2019

install it, start python and try to import the python module

@maxice8
Copy link
Contributor

maxice8 commented Jan 15, 2019

image

@ndowens
Copy link
Contributor Author

ndowens commented Jan 15, 2019

It doesn’t have that file to patch anymore but I MIGHT know how to fix it

Edit: seems the library _libolm isn’t being built

@ndowens ndowens changed the title olm: update to 3.0.0 [NOMERGE]olm: update to 3.0.0 Jan 15, 2019
@ndowens
Copy link
Contributor Author

ndowens commented Jan 15, 2019

Going to contact upstream and see what can be done

@ndowens
Copy link
Contributor Author

ndowens commented Jan 17, 2019

@maxice8 This worked for me, no import error(tested python3)

@ndowens ndowens changed the title [NOMERGE]olm: update to 3.0.0 olm: update to 3.0.0 Jan 17, 2019
@ndowens ndowens changed the title olm: update to 3.0.0 [WIP]olm: update to 3.0.0 Jan 17, 2019
@ndowens ndowens changed the title [WIP]olm: update to 3.0.0 olm: update to 3.0.0 Jan 17, 2019
maintainer="Adam Beckmeyer <adam_gpg@thebeckmeyers.xyz>"
license="Apache-2.0"
homepage="https://git.matrix.org/git/olm/about/"
distfiles="https://git.matrix.org/git/olm/snapshot/${pkgname}-${version}.tar.gz"
checksum=533714fb84860e04c185790d16ef9085f15e902c2105db941d5c7e92b0565ef8
checksum=4c54f93e4f426a9d5c8e66e63113d42fd2afca240cdcff30a469a342a6ec3bc6
nocross=yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why mark it nocross? It was possible to cross-compile before, the package is in the aarch64 repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the install stage it uses the host gcc instead of target’s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An it isn't possible to find a way around that or patch it to do the right thing? Adding nocross to new packages that simply cannot be crosscompiled is one thing but setting existing packages nocross means the repositories have to be cleaned up manually and people already using a package on cross-compiled architectures will loose functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try more, as I was trying to avoid setting nocross

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After digging more into it, seems it is CFFI causing issues

@ndowens
Copy link
Contributor Author

ndowens commented Jan 18, 2019

I can not fix cross-compile, no matter if I try to override LD, something with cffi uses host's ld

@ndowens ndowens closed this Jan 18, 2019
@ndowens
Copy link
Contributor Author

ndowens commented Jan 18, 2019

matrix-org/olm#16 This is the bug report, so hopefully it will be fixed in the future, so this package can be updated to be cross-friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants