Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: update to 3.7.3 #42361

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

mdkcore0
Copy link
Contributor

@mdkcore0 mdkcore0 commented Feb 20, 2023

Testing the changes

  • I tested the changes in this PR: yes

Local build testing

  • I built this PR locally for my native architecture, (x86_64-lib)
  • armv7l (crossbuild)
  • i686-libc

Also:

@mdkcore0 mdkcore0 force-pushed the update-nextcloud branch 2 times, most recently from 9dd4905 to e54f388 Compare February 20, 2023 20:15
@mdkcore0 mdkcore0 marked this pull request as ready for review February 20, 2023 20:15
@mdkcore0
Copy link
Contributor Author

I'm getting this error while trying to build the package on armv7l (cross):

-- The following REQUIRED packages have not been found:

 * Qt5WebEngineWidgets (required version >= 5.15.0), Qt5 WebEngineWidgets component.
 * Qt5WebEngine (required version >= 5.15.0), Qt5 WebEngine component.

It failed here on Actions as well; seems the qt5-webengine package is missing from the armv6l and armv7l taget architectures.

Is it a known issue? Can't find something related in the issues tab (also the logs from the latest update are not available anymore)

@classabbyamp
Copy link
Member

classabbyamp commented Feb 22, 2023

Is it a known issue?

https://github.com/void-linux/void-packages/blob/master/srcpkgs/qt5-webengine/template#L56, but it's weird that it didn't fail successfully

@mdkcore0
Copy link
Contributor Author

https://github.com/void-linux/void-packages/blob/master/srcpkgs/qt5-webengine/template#L56, but it's weird that it didn't fail successfully

yeah, this is pretty strange as it was working flawlessly in the last time I've updated ths package; will was on IRC later today

@mdkcore0
Copy link
Contributor Author

they have made WebEngine mandatory now, I've asked on their repo for a solution, and will try to figure out a way to remove this dependency in the meantime

@TimB87
Copy link

TimB87 commented Feb 23, 2023

You can revert the commit in the meantime like I did for CRUX: https://crux.nu/gitweb/?p=ports/contrib.git;a=commit;h=a3b7ed365b04b37bcbc5390e5a9b0c5c0578bbc2

not the most elegant solution, but oh well.. that wasn't the most elegant commit upstream either

hope that helps 👋

@mdkcore0
Copy link
Contributor Author

You can revert the commit in the meantime like I did for CRUX: https://crux.nu/gitweb/?p=ports/contrib.git;a=commit;h=a3b7ed365b04b37bcbc5390e5a9b0c5c0578bbc2

not the most elegant solution, but oh well.. that wasn't the most elegant commit upstream either

hope that helps wave

yeah, will do that, many thanks @TimB87!

@ahesford
Copy link
Member

ahesford commented Feb 23, 2023

This probably ought to be guarded by a build option, where the default is to not revert the change and depend on qt5-webengine, except for those arches where we don't build that package.

Ignore me; I didn't expand the template to see that this is already the case.

Also:
- Add karchive as dependency [1]
- Add patch to revert mandatory WebEngine dependency [2]

[1] nextcloud/desktop#4768
[2] nextcloud/desktop#4875
@paper42 paper42 merged commit 36f6c29 into void-linux:master Mar 9, 2023
@mdkcore0 mdkcore0 deleted the update-nextcloud branch March 9, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants