Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: rust-analyzer-2020.09.14 #23623

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

gbrlsnchs
Copy link
Contributor

No description provided.

srcpkgs/rust-analyzer/template Outdated Show resolved Hide resolved
@ericonr
Copy link
Member

ericonr commented Aug 9, 2020

Does it make sense to have this as a system package? It goes hand in hand with rust development, for which someone would likely be using rustup. And it gets releases like crazy: https://github.com/rust-analyzer/rust-analyzer/releases

This installation step seems to indicate it depends on rustup, unless it can download sources without rustup: https://rust-analyzer.github.io/manual.html#installation ?

@gbrlsnchs
Copy link
Contributor Author

Does it make sense to have this as a system package? It goes hand in hand with rust development, for which someone would likely be using rustup. And it gets releases like crazy: https://github.com/rust-analyzer/rust-analyzer/releases

Currently, rust-analyzer is distributed as binary only, not via rustup, so I think it makes sense to distribute it for now via XBPS. There was a discussion about whether it should be distributed via rustup, but nothing has changed since then.

This installation step seems to indicate it depends on rustup, unless it can download sources without rustup: https://rust-analyzer.github.io/manual.html#installation ?

It's not a hard dependency, it simply needs rust-src in order for autocompletion and stuff to work properly.

@ericonr
Copy link
Member

ericonr commented Aug 11, 2020

I must have understood rust-lang/rust-analyzer#4224 wrong, it says that it's packaged with rustup already. But yeah, I couldn't download it with rustup :/

@gbrlsnchs gbrlsnchs changed the title New package: rust-analyzer-2020.07.13 New package: rust-analyzer-2020.09.14 Sep 15, 2020
@gbrlsnchs
Copy link
Contributor Author

I updated the package to the latest version.

@gbrlsnchs gbrlsnchs requested a review from jnbr September 15, 2020 19:05
@gbrlsnchs gbrlsnchs closed this Sep 21, 2020
@gbrlsnchs gbrlsnchs deleted the rust-analyzer branch September 21, 2020 14:58
@gbrlsnchs gbrlsnchs restored the rust-analyzer branch September 21, 2020 22:11
@gbrlsnchs gbrlsnchs reopened this Sep 21, 2020
Copy link
Contributor

@jnbr jnbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Sorry for the long delay.

I will merge it when CI passed.

@gbrlsnchs
Copy link
Contributor Author

Looks good to me.
Sorry for the long delay.

I will merge it when CI passed.

Thanks. Do you want me to update it to the latest version? It just came out today...

@jnbr jnbr merged commit 03bbabe into void-linux:master Sep 21, 2020
@jnbr
Copy link
Contributor

jnbr commented Sep 21, 2020

I've seen you comment too late. Feel free to do the update in a new pull request.

@gbrlsnchs
Copy link
Contributor Author

No problem! Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants