Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update pretrained model url, raise error if there are no files to preprocess, shuffle files consistently #715

Merged
merged 3 commits into from
May 29, 2023

Conversation

34j
Copy link
Collaborator

@34j 34j commented May 29, 2023

Description of change

πŸ€– Generated by Copilot at 2f15ae2

Summary

πŸ“πŸ› οΈπŸš€

This pull request introduces several improvements and updates to the so-vits-svc-fork module, such as adding numpy as a dependency, using a fixed random seed, enhancing the error handling and code clarity of the preprocessing functions, updating the training and model loading methods, and adding the pretrained model URLs to the config templates. It also updates the README.md file and the default config type for the command line interface.

The so-vits-svc-fork repo
Has some changes that you should know
It has new configs and models
And some code that coddles
The users who want to train with quickvc

Walkthrough

  • Update README.md to use the latest branch name 4.1 (link)
  • Change default config type for command line interface to so-vits-svc-4.0v1 (link)
  • Add pretrained model URLs for quickvc, so-vits-svc-4.0v1-legacy, and so-vits-svc-4.0v1 configs to JSON files (link, link, link)
  • Modify ensure_pretrained_model function to accept model type or URLs dictionary and download models in parallel (link, link)
  • Pass pretrained model URLs from config file to ensure_pretrained_model function in train function (link)
  • Add DeviceStatsMonitor callback to monitor GPU usage and memory during training (link, link)
  • Import numpy module and create random state object for reproducible shuffling of paths in preprocess_config function (link, link)
  • Replace shuffle function with random.shuffle function that uses random state object in preprocess_config function (link)
  • Add check for empty input directory and raise ValueError in preprocess_resample function (link)
  • Remove redundant line that appends input path to in_paths list in preprocess_resample function (link)

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request follows Contributing.md
  • This pull request links relevant issues as Fixes #0000
  • pre-commit run -a passes with this change or ci passes
  • poetry run pytest passes with this change or ci passes
  • (There are new or updated unit tests validating the change)
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 38.88% and project coverage change: -0.03 ⚠️

Comparison is base (3940a4c) 19.52% compared to head (2f15ae2) 19.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   19.52%   19.50%   -0.03%     
==========================================
  Files          39       39              
  Lines        3431     3441      +10     
  Branches      477      481       +4     
==========================================
+ Hits          670      671       +1     
- Misses       2744     2752       +8     
- Partials       17       18       +1     
Impacted Files Coverage Ξ”
src/so_vits_svc_fork/__main__.py 0.00% <ΓΈ> (ΓΈ)
src/so_vits_svc_fork/utils.py 21.63% <0.00%> (-0.64%) ⬇️
...vits_svc_fork/preprocessing/preprocess_resample.py 69.69% <50.00%> (-2.62%) ⬇️
src/so_vits_svc_fork/train.py 21.56% <50.00%> (+0.30%) ⬆️
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ΓΈ)
..._svc_fork/preprocessing/preprocess_flist_config.py 90.90% <100.00%> (+0.16%) ⬆️

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@34j 34j merged commit c4c719c into main May 29, 2023
@34j 34j deleted the feat/update-pretrained-url branch May 29, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant