Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing and unparsing ascii files with escaped characters and NA strings #44

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

trossi
Copy link
Contributor

@trossi trossi commented Sep 11, 2024

Describe the proposed changes

The PR will

  • fix parsing and unparsing ascii files with strings including e.g. '?' and some other characters
  • fix unparsing ascii files with NA strings
  • add test files for the corresponding cases (R code used to generate the test files added in the comment of tests)

Additional information

A test file is added in xdr format too to check that there is no issues there (there was none).

Checklist before requesting a review

  • I have performed a self-review of my code
  • The code conforms to the style used in this package (checked with Ruff)
  • The code is fully documented and typed (type-checked with Mypy)
  • I have added thorough tests for the new/changed functionality

@trossi trossi changed the title Fix parsing and unparsing ascii files with escaped characters Fix parsing and unparsing ascii files with escaped characters and NA strings Sep 13, 2024
@trossi
Copy link
Contributor Author

trossi commented Sep 13, 2024

I pushed a fix for unparsing NA strings too and updated the PR description accordingly.

Copy link
Owner

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment/question. The rest seems fine.

Copy link
Owner

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnmabus vnmabus merged commit d65ec51 into vnmabus:develop Oct 7, 2024
15 checks passed
@trossi trossi deleted the fix-ascii branch October 29, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants