Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vcfa_vcenter resource + data source #2

Merged
merged 11 commits into from
Jan 20, 2025
Merged

Add vcfa_vcenter resource + data source #2

merged 11 commits into from
Jan 20, 2025

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jan 16, 2025 •
edited
Loading

Add vcfa_vcenter resource and data source

Additionally:

  • Introduce generic resource management approach
  • Leftover removal mechanism + vcfa_vcenter cleanup (make cleanup starts working)
  • Consumption protection that enforces API V40 requirement

Ref: vmware/terraform-provider-vcd#1343

@Didainius
Add vcfa_vcenter resource + data source
a7d5315 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius
Fix go mod
d983a5d 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius
Add docs, patch errors
ae4a19e 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius
review
501cdeb 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius
Self review
ce5d625 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius Didainius marked this pull request as ready for review January 17, 2025 08:55
@Didainius
Changelog naming
e0d9c66 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
adambarreiro
adambarreiro reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things, will try to run the tests and approve

website/vcfa.erb Show resolved Hide resolved
.changes/v1.0.0/2-feature.md Outdated Show resolved Hide resolved
@Didainius
Address comments
34a6965 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
adambarreiro
adambarreiro approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed for me make testacc

@Didainius
improve changelog
11e8302 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius
Convert * to - in changelog bullets
9d271ba 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius
Address comment, store tainted vCenter ID when error occurs
57bf95b 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
lvirbalas
lvirbalas approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in!

@Didainius
Bump go.mod
3bdd7bb 
Signed-off-by: Dainius <Didainius@users.noreply.github.com>
@Didainius Didainius merged commit ebd8fba into vmware:main Jan 20, 2025
1 check passed
@Didainius Didainius deleted the vcenter-pr branch January 20, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Didainius @adambarreiro @lvirbalas