Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the design of velero debug #4081

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

reasonerjt
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

After the PR to implement velero debug - #4022 is reviewed, there are some
suggestion to let the command collect more resources, this commit make
the change to the design doc to reflect those changes.

It also remove some sections that are no longer relevant after crashd
has made enhancement in the v0.3.4 release.

Please indicate you've done the following:

@reasonerjt reasonerjt added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Aug 31, 2021
@github-actions github-actions bot added the Area/Design Design Documents label Aug 31, 2021
@github-actions github-actions bot requested review from ywk253100 and zubron August 31, 2021 10:47
@reasonerjt reasonerjt requested a review from dsu-igeek August 31, 2021 13:13
zubron
zubron previously approved these changes Aug 31, 2021
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@ywk253100
Copy link
Contributor

Should we include the change introduced by #4102?

@reasonerjt
Copy link
Contributor Author

Updated the markdown file to incorporate the latest changes of the scripts, and moved the file to implemented folder

After the PR to implement `velero debug` - vmware-tanzu#4022 is reviewed, there are some
suggestion to let the command collect more resources, this commit make
the change to the design doc to reflect those changes.

It also remove some sections that are no longer relevant after `crashd`
has made enhancement in the v0.3.4 release.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@zubron zubron merged commit 430410c into vmware-tanzu:main Oct 25, 2021
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Jan 25, 2022
After the PR to implement `velero debug` - vmware-tanzu#4022 is reviewed, there are some
suggestion to let the command collect more resources, this commit make
the change to the design doc to reflect those changes.

It also remove some sections that are no longer relevant after `crashd`
has made enhancement in the v0.3.4 release.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
After the PR to implement `velero debug` - vmware-tanzu#4022 is reviewed, there are some
suggestion to let the command collect more resources, this commit make
the change to the design doc to reflect those changes.

It also remove some sections that are no longer relevant after `crashd`
has made enhancement in the v0.3.4 release.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Design Design Documents kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants