-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the design of velero debug
#4081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
added
the
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
label
Aug 31, 2021
zubron
previously approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this!
Should we include the change introduced by #4102? |
Updated the markdown file to incorporate the latest changes of the scripts, and moved the file to |
After the PR to implement `velero debug` - vmware-tanzu#4022 is reviewed, there are some suggestion to let the command collect more resources, this commit make the change to the design doc to reflect those changes. It also remove some sections that are no longer relevant after `crashd` has made enhancement in the v0.3.4 release. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
reasonerjt
force-pushed
the
update-debug-design
branch
from
October 25, 2021 02:10
1f6f944
to
b93e25f
Compare
ywk253100
approved these changes
Oct 25, 2021
zubron
approved these changes
Oct 25, 2021
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jan 25, 2022
After the PR to implement `velero debug` - vmware-tanzu#4022 is reviewed, there are some suggestion to let the command collect more resources, this commit make the change to the design doc to reflect those changes. It also remove some sections that are no longer relevant after `crashd` has made enhancement in the v0.3.4 release. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
After the PR to implement `velero debug` - vmware-tanzu#4022 is reviewed, there are some suggestion to let the command collect more resources, this commit make the change to the design doc to reflect those changes. It also remove some sections that are no longer relevant after `crashd` has made enhancement in the v0.3.4 release. Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area/Design
Design Documents
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
After the PR to implement
velero debug
- #4022 is reviewed, there are somesuggestion to let the command collect more resources, this commit make
the change to the design doc to reflect those changes.
It also remove some sections that are no longer relevant after
crashd
has made enhancement in the
v0.3.4
release.Please indicate you've done the following:
/kind changelog-not-required
.site/content/docs/main
.