-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dhcp validation to prevent switch from DHCPServer/DHCPRelay to DHCPDeactivated #996
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
=======================================
Coverage 74.08% 74.08%
=======================================
Files 118 118
Lines 16362 16362
=======================================
Hits 12122 12122
Misses 3466 3466
Partials 774 774
|
9b96864
to
9f2d05f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… DHCPDeactivated Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
9f2d05f
to
729ce25
Compare
Removed the e2e test for dhcp switch for now as the current e2e testbed does not apply crd for each run and the current e2e test for switch is not well-designed for the new case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… DHCPDeactivated (vmware-tanzu#996) Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
According to NSX change that we would not support static IP Allocation modification.
We add rules to only allow the DHCP mode switch between DHCPServer and DHCPRelay.
Testing done: