Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest versions (along with the wasi-sdk-20 builds) #110

Merged
merged 6 commits into from
Jun 23, 2023

Conversation

assambar
Copy link
Contributor

@assambar assambar commented Jun 21, 2023

  • Add latest versions for libxml2, ruby, php, python
  • Made dependencies declarative via wlr-info.json, which shall also contain the rest of the information with time (currently spread in wlr-*.sh scripts)
  • Added basic smoke test with sqlite and python.
  • Slim version of ruby and php will be added subsequently and libraries will be published subsequently.

assambar added 3 commits June 19, 2023 14:34
 - use json file to describe dependencies
 - ensure same wasi-sdk version when downloading dependencies
 - small build script fixes, logs, etc.
@assambar assambar marked this pull request as ready for review June 23, 2023 08:01
@assambar assambar changed the title Latest versions Bump to latest versions (along with the wasi-sdk-20 builds Jun 23, 2023
@assambar assambar changed the title Bump to latest versions (along with the wasi-sdk-20 builds Bump to latest versions (along with the wasi-sdk-20 builds) Jun 23, 2023
@gzurl gzurl self-requested a review June 23, 2023 08:15
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @assambar

@@ -16,6 +16,11 @@ jobs:
include:
- version: 3.2.0
target_version: 3_2_0
- version: 3.2.2
target_version: 3_2_2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, do we want to support all of them?

@gzurl
Copy link
Contributor

gzurl commented Jun 23, 2023

@assambar, the PR LGTM, great work!

I would double-check new builds with our current demos.
For instance, we could check PHP 8.2.6 with the Drupal demo by updating the Dockerfile and performing manual inspection (ie: setup, a new page, attaching pictures, etc.).

@assambar assambar merged commit 2993864 into main Jun 23, 2023
@assambar assambar deleted the latest-versions branch June 23, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants