Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): datagrid - invalid aria-attributes in manage column #1684

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

venkateshr06
Copy link
Contributor

@venkateshr06 venkateshr06 commented Jan 28, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?
Fix for Accessibility issues

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

aria-expanded property is not added to the element since default value is set to undefined. Without this property, aria-controls and aria-owns will be an invalid property.

Issue Number: CDE-2542, VPAT-28111

What is the new behavior?

Added aria-haspopup attribute and aria-expanded property set to false by default.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@venkateshr06 venkateshr06 self-assigned this Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

👋 @venkateshr06,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants