This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#157
https://github.com/vmstan/gravity-sync/discussions/158
When the script gs-core.sh is executed or sourced, the
$RH_EXEC
command is actually parsed on the local machine, and then used against the remote machine. This can lead to checking for a non-existent container name on the remote server, instead of properly parsing the remote system's configuration.Example:
On load,
becomes
sudo /usr/bin/docker exec 0ce8b1d5571d pihole
, which is then used in an SSH command against the remote host, yielding:because, of course, the container ID doesn't exist on the remote host.
The fix is to escape the nested command execution within
gs-core.sh
, like so: