Fix beam search eos #9627
Merged
Fix beam search eos #9627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
njhill
approved these changes
Oct 23, 2024
cooleel
pushed a commit
to cooleel/vllm
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
cooleel
pushed a commit
to cooleel/vllm
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
Signed-off-by: qishuai <ferdinandzhong@gmail.com>
rasmith
pushed a commit
to rasmith/vllm
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
Signed-off-by: NickLucche <nlucches@redhat.com>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Oct 31, 2024
Signed-off-by: NickLucche <nlucches@redhat.com>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Linkun Chen <github+anyscale@lkchen.net>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
beam_searchvia the api is including the eos token in the texttokenizer.decode(xxx, skip_special_tokens=True)because this strips out all the special tokens in chat templates