Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix clean shutdown issues #8492

Merged
merged 4 commits into from
Sep 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
another test fix
  • Loading branch information
njhill committed Sep 16, 2024
commit 37f7f04179c8db18a10ef6ff0cba356bb68cc6be
6 changes: 6 additions & 0 deletions tests/async_engine/test_async_llm_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ class RequestOutput:
finished: bool = False


@dataclass
class MockModelConfig:
use_async_output_proc = True


class MockEngine:

def __init__(self):
Expand All @@ -35,6 +40,7 @@ def __init__(self):
self.request_id = None
# Ugly, remove dependency when possible
self.parallel_config = ParallelConfig(1, 1, False)
self.model_config = MockModelConfig()

async def step_async(self, virtual_engine):
# PP size is 1, ignore virtual engine
Expand Down
Loading