Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypy][CI/Build] Fix mypy errors #7929

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[mypy][CI/Build] Fix mypy errors #7929

merged 3 commits into from
Aug 28, 2024

Conversation

DarkLight1337
Copy link
Member

Merging #7229 caused some mypy errors in CI even though the PR itself passed the check. This PR fixes the newly appearing errors.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like reasonable changes, thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 27, 2024 23:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 27, 2024
@simon-mo simon-mo merged commit 51f86bf into vllm-project:main Aug 28, 2024
39 of 44 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-mypy-errors branch August 28, 2024 06:48
kushanam pushed a commit to kushanam/vllm that referenced this pull request Aug 28, 2024
hbikki pushed a commit to hbikki/vllm that referenced this pull request Aug 28, 2024
kushanam pushed a commit to kushanam/vllm that referenced this pull request Aug 28, 2024
triple-Mu pushed a commit to triple-Mu/vllm_official that referenced this pull request Sep 4, 2024
Jeffwan pushed a commit to aibrix/vllm that referenced this pull request Sep 19, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants