Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Mirror jinja2 in pyproject.toml #7723

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[Bugfix] Mirror jinja2 in pyproject.toml #7723

merged 1 commit into from
Aug 21, 2024

Conversation

sasha0552
Copy link
Contributor

In #7695, jinja2 was added to requirements-build.txt but was not mirrored in pyproject.toml, causing build errors in a clean environment such as cibuildwheel.

https://github.com/sasha0552/pascal-pkgs-ci/actions/runs/10485853952/job/29042838246

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@sasha0552
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 21, 2024
DarkLight1337
DarkLight1337 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 21, 2024 08:13
@DarkLight1337 DarkLight1337 merged commit dd3fa0e into vllm-project:main Aug 21, 2024
42 checks passed
@sasha0552 sasha0552 deleted the build-fix branch August 21, 2024 15:56
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Aug 21, 2024
@sasha0552 @patrickvonplaten
[Bugfix] Mirror jinja2 in pyproject.toml (vllm-project#7723)
fc3d456
omrishiv pushed a commit to omrishiv/vllm that referenced this pull request Aug 26, 2024
@sasha0552 @omrishiv
[Bugfix] Mirror jinja2 in pyproject.toml (vllm-project#7723)
4afa8d2
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@sasha0552 @Alvant
[Bugfix] Mirror jinja2 in pyproject.toml (vllm-project#7723)
610e257 
Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@sasha0552
[Bugfix] Mirror jinja2 in pyproject.toml (vllm-project#7723)
dec9e6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasha0552 @DarkLight1337