-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hardware][Intel CPU] Update torch 2.4.0 for CPU backend #6931
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
Hi @DamonFool , sorry for the late. I think you can change the title as update torch 2.4.0 for CPU backend and mark the PR as ready to trigger full CI run. Thanks! |
/ready |
Done. |
Hi @bigPYJ1151 , the failing tests are all running on GPUs which should not be affected by this change. |
Hi @bigPYJ1151 , I would suggest fixing this bug as soon as possible since this is a build failure. |
Hi @mgoin , would you please help to merge this PR as it passed the CPU tests? Thanks! |
Thanks @simon-mo for your help. |
…t#6931) Signed-off-by: Alvant <alvasian@yandex.ru>
The CPU targets of vLLM fail to build with the following error.
The reason is that not cpu-only torch is installed.
I guess we should install torch from
https://download.pytorch.org/whl/cpu
as before.After this patch, cpu-only torch can be installed and the build passed.
Please review it.
Thanks.