-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Add moondream vision language model #4228
base: main
Are you sure you want to change the base?
Conversation
7030ae7
to
cca8c3a
Compare
Thanks for expanding the list of supported multimodal models! Could you add a test to ensure that the model is consistent with its HuggingFace implementation? (Similar to To facilitate #4194, it would be great if you could also wrap the image preprocessing logic inside of a HuggingFace image processor so it can be loaded by |
Hello! @vikhyat Thank you for the contribution and I'm excited to have this model supported in vLLM. We have done a significant amount of refactoring on vLLM for supporting multimodal models in the last 2 months - please see updates in #4194. If you don't mind, I'm happy to update this PR accordingly so we can get this merged. Let me know! |
Hi @ywang96! I had this in my backlog but I'm currently swamped trying to get a new version of the model trained and released, so it has been hard to find the time. I would definitely hugely appreciate it if you can help out! |
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
This pull request has merge conflicts that must be resolved before it can be |
Ooops - Feel free to ignore the comment from the bot. (I do still need to spend some time working on this model...) |
👀 |
Very relevant now that a major update has been released today. Great model |
@ValeryNo I've spoken to vik about this and spent some time myself on this model, but unfortunately we don't support PrefixLM attention as of now (but will likely do via FlexAttention in the future). |
This pull request adds support for the moondream vision language model, added similar to how the LLaVA implementation works.
Usage:
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!