Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Model] OLMo 2: split qkv correctly for GQA and MQA #13687

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

2015aroras
Copy link
Contributor

@2015aroras 2015aroras commented Feb 21, 2025

Issue: OLMo 2 does not correctly do attention when the number of heads is not the same as the number of kv heads (i.e. GQA or MQA is used instead of MHA). Specifically, it splits qkv into equal chunks rather than chunks based on q, k, v size.

Fix: Split qkv based on q, k, v size.

Testing: We ran this internally on a model that uses GQA.

FIX #13686

Signed-off-by: Shane A <shanea@allenai.org>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) February 22, 2025 02:35
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 22, 2025
@simon-mo simon-mo merged commit 9a1f1da into vllm-project:main Feb 22, 2025
58 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OLMo 2 does not split qkv correctly for grouped query attention
3 participants