Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Capture and log the time of loading weights #13666

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

waltforme
Copy link
Contributor

@waltforme waltforme commented Feb 21, 2025

This PR tries to introduce more transparency to weights loading.

Today we're already logging the memory footprint Loading model weights took X GB.
We can do even better by also logging the time consumption like Loading model weights took X seconds.

Signed-off-by: Jun Duan <jun.duan.phd@outlook.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill
Copy link
Member

njhill commented Feb 21, 2025

@waltforme could we add it in the same log statement as the size, to avoid an extra line in the logs?

Signed-off-by: Jun Duan <jun.duan.phd@outlook.com>
Signed-off-by: Jun Duan <jun.duan.phd@outlook.com>
@waltforme
Copy link
Contributor Author

@waltforme could we add it in the same log statement as the size, to avoid an extra line in the logs?

@njhill Great idea!
I merged it with the log statement for the size.
Also added same logging for V0.

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waltforme

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 22, 2025 06:06
@simon-mo simon-mo merged commit 68d535e into vllm-project:main Feb 22, 2025
51 of 58 checks passed
@waltforme waltforme deleted the load-time branch February 28, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants