Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Sampler] Avoid an operation during temperature application #13587

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

njhill
Copy link
Member

@njhill njhill commented Feb 20, 2025

We can just set greedy entries to -1.0 and then there's no need to replace those entries when we sample.

We can just set greedy entries to -1.0 and then there's no need to replace those entries when we sample.

Signed-off-by: Nick Hill <nhill@redhat.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 20, 2025
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement! I left two minor comments, PTAL!

Signed-off-by: Nick Hill <nhill@redhat.com>
@njhill
Copy link
Member Author

njhill commented Feb 20, 2025

Thanks @ywang96, good comments!

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 20, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 21, 2025 06:05
@simon-mo simon-mo merged commit 31aa045 into vllm-project:main Feb 21, 2025
48 of 56 checks passed
michaelrglass pushed a commit to michaelrglass/vllm that referenced this pull request Feb 21, 2025
@njhill njhill deleted the simpler-temp branch February 21, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants