-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1][Sampler] Avoid an operation during temperature application #13587
Conversation
We can just set greedy entries to -1.0 and then there's no need to replace those entries when we sample. Signed-off-by: Nick Hill <nhill@redhat.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement! I left two minor comments, PTAL!
Signed-off-by: Nick Hill <nhill@redhat.com>
Thanks @ywang96, good comments! |
…-project#13587) Signed-off-by: Michael Glass <mrglass@us.ibm.com>
We can just set greedy entries to -1.0 and then there's no need to replace those entries when we sample.