Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP Server] Make model param optional in request #13568

Merged
merged 5 commits into from
Feb 22, 2025

Conversation

youngkent
Copy link
Contributor

@youngkent youngkent commented Feb 19, 2025

We often have single model per deployment setup. Requiring model name in request create unnecessary coupling between service and client. This change make "model" param optional. When not given, it uses the first available model on the server to serve the request.

Test before the change, one need to send request like:

curl --insecure https://localhost:8000/v1/chat/completions \                                                                                                          
     -H "Content-Type: application/json" \
     -d '{
           "model": "/packages/8B_model",     
           "messages": [{"role": "user", "content": "Hello, vLLM!"}],
           "max_tokens": 100
         }' 

After the change, one can send the request like:

curl --insecure https://localhost:8000/v1/chat/completions \                                                                                                          
     -H "Content-Type: application/json" \
     -d '{ 
           "messages": [{"role": "user", "content": "Hello, vLLM!"}],
           "max_tokens": 100
         }' 

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 19, 2025
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youngkent Thanks for submitting the PR!
It looks good to me, but maybe we need a second eye as I'm not very familiar with the frontend stuffs.

@simon-mo
Copy link
Collaborator

While this is breaking OpenAI compatibility/semantics, I actually think it's the right thing to do because vLLM only support one instance of the model anyway!

@simon-mo
Copy link
Collaborator

cc @DarkLight1337 @njhill

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change one of the entrypoint test to reflect this behavior.

@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 21, 2025 04:09
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this was proposed in the past and decided against, but can't find the issue/PR now. In any case I don't remember why and I am also in favor of this.

Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
auto-merge was automatically disabled February 21, 2025 06:41

Head branch was pushed to by a user without write access

@youngkent
Copy link
Contributor Author

The huggingface file downloading error seems not relevant. Can I get a manual merge please? Thanks!
cc: @WoosukKwon @simon-mo @DarkLight1337 @njhill

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 22, 2025 05:55
@simon-mo simon-mo merged commit 0ffdf8c into vllm-project:main Feb 22, 2025
37 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants