-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTTP Server] Make model param optional in request #13568
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youngkent Thanks for submitting the PR!
It looks good to me, but maybe we need a second eye as I'm not very familiar with the frontend stuffs.
While this is breaking OpenAI compatibility/semantics, I actually think it's the right thing to do because vLLM only support one instance of the model anyway! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change one of the entrypoint test to reflect this behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this was proposed in the past and decided against, but can't find the issue/PR now. In any case I don't remember why and I am also in favor of this.
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Signed-off-by: Keyun Tong <tongkeyun@gmail.com>
Head branch was pushed to by a user without write access
The huggingface file downloading error seems not relevant. Can I get a manual merge please? Thanks! |
We often have single model per deployment setup. Requiring model name in request create unnecessary coupling between service and client. This change make "model" param optional. When not given, it uses the first available model on the server to serve the request.
Test before the change, one need to send request like:
After the change, one can send the request like: