Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Platform][CPU] Fix cuda platform detection on CPU backend edge case #13358

Merged
merged 2 commits into from
Feb 16, 2025
Merged

[Bugfix][Platform][CPU] Fix cuda platform detection on CPU backend edge case #13358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd89592
fix cuda platform detect
Isotr0py Feb 16, 2025
9bcef45
fix cuda platform activation
Isotr0py Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions vllm/platforms/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,19 @@ def cuda_platform_plugin() -> Optional[str]:
is_cuda = False

try:
from importlib.metadata import version

from vllm.utils import import_pynvml
pynvml = import_pynvml()
pynvml.nvmlInit()
try:
if pynvml.nvmlDeviceGetCount() > 0:
is_cuda = True
# NOTE: Edge case: vllm cpu build on a GPU machine.
# Third-party pynvml can be imported in cpu build,
# we need to check if vllm is built with cpu too.
# Otherwise, vllm will always activate cuda plugin
# on a GPU machine, even if in a cpu build.
is_cuda = (pynvml.nvmlDeviceGetCount() > 0
and "cpu" not in version("vllm"))
finally:
pynvml.nvmlShutdown()
except Exception as e:
Expand Down