Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] MLA decode attention - cuda graph support #12588

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

[WIP] MLA decode attention - cuda graph support #12588

wants to merge 12 commits into from

Conversation

alexm-redhat
Copy link
Collaborator

Adds cuda graph support to Lucas' PR that implements triton MLA attention kernel: #12528

LucasWilkinson and others added 11 commits January 30, 2025 03:18
@LucasWilkinson @WoosukKwon @simon-mo
squashed commits
ec8c1cf 
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Co-authored-by: simon-mo <simon.mo@hey.com>
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@LucasWilkinson
fix VLLM_MLA_PERFORM_MATRIX_ABSORPTION=0
f23d126 
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@LucasWilkinson
more cleanups
3895bba 
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@LucasWilkinson @mgoin
Update utils.py
4880a43 
Co-authored-by: Michael Goin <mgoin64@gmail.com>
@LucasWilkinson @mgoin
Update vllm/attention/backends/mla/utils.py
aa19f29 
Co-authored-by: Michael Goin <mgoin64@gmail.com>
@LucasWilkinson
review comments
534cd00 
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@LucasWilkinson
renaming for consistency
2326814 
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@LucasWilkinson @zhuohan123
Update vllm/config.py
2b140de 
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
@LucasWilkinson
review comments
7241acb 
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@LucasWilkinson
review comments
135c404 
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@alexm-redhat
add cuda graph support to triton_mla attention
984ffdd
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-redhat alexm-redhat marked this pull request as draft January 30, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexm-redhat @LucasWilkinson