Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU][PPC] Updated torch, torchvision, torchaudio dependencies #12555

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[CPU][PPC] Updated torch, torchvision, torchaudio dependencies #12555

merged 1 commit into from
Jan 30, 2025

Conversation

npanpaliya
Copy link
Contributor

@npanpaliya npanpaliya commented Jan 29, 2025 •
edited by github-actions bot
Loading

Updated ppc64le requirements for torch, torchvision and torchaudio to the same versions used on other architectures.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 29, 2025
@npanpaliya
Updated torch, torchvision, torchaudio dependencies
4be824f 
Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
@DarkLight1337
Copy link
Member

cc @bigPYJ1151

mgoin
mgoin approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you think you could add a doc page for ppc in the cpu installation guide? https://github.com/vllm-project/vllm/tree/main/docs/source/getting_started/installation/cpu

@mgoin mgoin added x86-cpu Related to Intel & AMD CPU ready ONLY add when PR is ready to merge/full CI is needed and removed x86-cpu Related to Intel & AMD CPU labels Jan 29, 2025
@mgoin mgoin changed the title Updated torch, torchvision, torchaudio dependencies [CPU][PPC] Updated torch, torchvision, torchaudio dependencies Jan 29, 2025
@npanpaliya
Copy link
Contributor Author

LGTM, do you think you could add a doc page for ppc in the cpu installation guide? https://github.com/vllm-project/vllm/tree/main/docs/source/getting_started/installation/cpu

Yes @mgoin, we do have plan to add documentation for ppc64le but probably not part of this PR. We are working on updating the documentation, once done, we will raise a new PR for it. Will that be fine?

@mgoin
Copy link
Member

mgoin commented Jan 30, 2025

Yes that is fine, thanks for letting us know

@mgoin mgoin merged commit bd2107e into vllm-project:main Jan 30, 2025
84 checks passed
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@npanpaliya @Isotr0py
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
1957e47 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
youngkent pushed a commit to youngkent/vllm that referenced this pull request Feb 3, 2025
@npanpaliya @youngkent
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
1441abf 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
srikanthsrnvs pushed a commit to srikanthsrnvs/vllm that referenced this pull request Feb 3, 2025
@npanpaliya @srikanthsrnvs
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
f7a4e12 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Srikanth Srinivas <srikanth@astrum.ai>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
@npanpaliya @NickLucche
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
0bc2ade 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
@npanpaliya @ShangmingCai
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
b82fa82 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
@npanpaliya @GWS0428
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
fb03990 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
@npanpaliya @panf2333
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
df9aea0 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
@npanpaliya @kerthcet
[CPU][PPC] Updated torch, torchvision, torchaudio dependencies (vllm-…
394ea54 
…project#12555)

Signed-off-by: npanpaliya <nishidha.panpaliya@partner.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@npanpaliya @DarkLight1337 @mgoin @jeejeelee