[Frontend] Generate valid tool call IDs when using tokenizer-mode=mistral

vllm/entrypoints/openai/serving_chat.py

@@ -28,6 +28,7 @@
 from vllm.outputs import CompletionOutput, RequestOutput
 from vllm.sampling_params import BeamSearchParams, SamplingParams
 from vllm.sequence import Logprob
+from vllm.utils import generate_valid_mistral_tool_id
 from vllm.transformers_utils.tokenizer import AnyTokenizer, MistralTokenizer
 from vllm.transformers_utils.tokenizers import maybe_serialize_tool_calls
 
@@ -710,6 +711,11 @@
                     "completion.")
                 message = ChatMessage(role=role, content=output.text)
 
+            if isinstance(tokenizer, MistralTokenizer):
+                for tool_call in message.tool_calls:
+                    tool_call.id = generate_valid_mistral_tool_id()
+                    logger.warning(f"Assigned new tool_id: {tool_call.id} for tool: {tool_call}")
+
             choice_data = ChatCompletionResponseChoice(
                 index=output.index,
                 message=message,

vllm/transformers_utils/tokenizers/mistral.py

@@ -18,7 +18,7 @@
                                                      Tekkenizer)
 
 from vllm.logger import init_logger
-from vllm.utils import is_list_of
+from vllm.utils import is_list_of, generate_valid_mistral_tool_id
 
 if TYPE_CHECKING:
     from vllm.entrypoints.chat_utils import ChatCompletionMessageParam
@@ -61,7 +61,9 @@
             while True:
                 try:
                     tool_call = next(tool_calls_validator)  # type: ignore
+                    tool_call['id'] = generate_valid_mistral_tool_id()
+                    logger.warning(f"Assigned new tool_id: {tool_call['id']} for tool: {tool_call}")
                     validated_tool_calls.append(tool_call)
                 except StopIteration:
                     break
 

vllm/utils.py

@@ -52,11 +52,16 @@
 import vllm.envs as envs
 from vllm.logger import enable_trace_function_call, init_logger
 
+from random import choices
+from string import ascii_letters, digits
+
 if TYPE_CHECKING:
     from vllm.config import VllmConfig
 
 logger = init_logger(__name__)
 
+ALPHANUMERIC = ascii_letters + digits
+
 # Exception strings for non-implemented encoder/decoder scenarios
 
 # Reminder: Please update docs/source/features/compatibility_matrix.md
@@ -2206,3 +2211,8 @@ def run_method(obj: Any, method: Union[str, bytes, Callable], args: Tuple[Any],
     else:
         func = partial(method, obj)  # type: ignore
     return func(*args, **kwargs)
+
+def generate_valid_mistral_tool_id():
+    # Mistral Tool Call Ids must be alphanumeric with a maximum length of 9.
+    # https://github.com/mistralai/mistral-common/blob/21ee9f6cee3441e9bb1e6ed2d10173f90bd9b94b/src/mistral_common/protocol/instruct/validator.py#L299
+    return "".join(choices(ALPHANUMERIC, k=9))