Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][V1] Fix 'NoneType' object has no attribute 'hash_value' #11157

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Dec 13, 2024

Exposed by #11151.

This bug has no impact on correctness nor performance.
Tested locally and benchmark serving can be done without errors.

cc @robertgshaw2-neuralmagic @WoosukKwon

Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 13, 2024
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) December 13, 2024 04:32
@tlrmchlsmth tlrmchlsmth merged commit 34f1a80 into vllm-project:main Dec 13, 2024
65 checks passed
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@comaniac comaniac deleted the v1-fix-cache branch January 3, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants