Skip to content

Commit

Permalink
Fix failures in test_long_context.
Browse files Browse the repository at this point in the history
The problem comes from new added field and the test didn't explicitly set the field but using position information.
  • Loading branch information
Jeffwan committed Jul 18, 2024
1 parent 0ea0d0d commit ba2a04d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/lora/test_long_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def _create_lora_request(lora_id, long_context_infos):
context_len = long_context_infos[lora_id]["context_length"]
scaling_factor = context_len_to_scaling_factor[context_len]
return LoRARequest(context_len, lora_id,
long_context_infos[lora_id]["lora"],
long_context_infos[lora_id]["lora"], None,
4096 * scaling_factor)


Expand Down
2 changes: 1 addition & 1 deletion vllm/lora/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __post_init__(self):
self.lora_path = self.lora_local_path or ""

# Ensure lora_path is not empty
assert self.lora_path, "lora_path can not be empty"
assert self.lora_path, "lora_path cannot be empty"

@property
def adapter_id(self):
Expand Down

0 comments on commit ba2a04d

Please sign in to comment.