Ignore worker pods for gateway routing #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Gupta <varungup90@gmail.com>
Jeffwan
reviewed
Mar 2, 2025
| @@ -75,6 +75,7 @@ type Block struct { | |||
|
|
|||
| const ( | |||
| modelIdentifier = "model.aibrix.ai/name" | |||
| nodeType = "ray.io/node-type" | |||
There was a problem hiding this comment.
I am thinking if we want to add a aibrix label like orchestration.aibrix.ai/server-pod. autoscaling need that feature as well. We can start with ray specific label and replace with our own later as a separate issue
There was a problem hiding this comment.
Agree, we have implement correctly in next iteration.
Signed-off-by: Varun Gupta <varungup90@gmail.com>
Signed-off-by: Varun Gupta <varungup90@gmail.com>
xieus
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Ignore worker pods for gateway routing * ignore worker pods in UpdatePod as well * use node worker as const Signed-off-by: Varun Gupta <varungup90@gmail.com> Signed-off-by: Liguang Xie <liguang.vt@gmail.com>
Jeffwan
pushed a commit
to Jeffwan/aibrix
that referenced
this pull request
Mar 6, 2025
* Ignore worker pods for gateway routing * ignore worker pods in UpdatePod as well * use node worker as const Signed-off-by: Varun Gupta <varungup90@gmail.com>
This was referenced Mar 6, 2025
Jeffwan
pushed a commit
to Jeffwan/aibrix
that referenced
this pull request
Mar 6, 2025
* Ignore worker pods for gateway routing * ignore worker pods in UpdatePod as well * use node worker as const Signed-off-by: Varun Gupta <varungup90@gmail.com>
Jeffwan
added a commit
that referenced
this pull request
Mar 6, 2025
* Ignore worker pods for gateway routing (#776) * Ignore worker pods for gateway routing * ignore worker pods in UpdatePod as well * use node worker as const Signed-off-by: Varun Gupta <varungup90@gmail.com> * Disable ENABLE_PROBES_INJECTION in correct way (#779) fix env error caused by helm set command, use —set-string for env bool Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Make stream include usage as optional (#788) * Make stream include usage as optional --------- Signed-off-by: Varun Gupta <varungup90@gmail.com> * Append ray head label selector in PodAutoscaler (#789) It helps to only consider the engine pod for multi-node inference. Ray worker doesn’t have http server running and it can not expose any application but only resource metrics. For resource metrics, since we use Tensor Parallelism, we think the utilization across GPU are same. Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Update request message processing for /v1/completion input (#794) Update request message processing for prompt input Signed-off-by: Varun Gupta <varungup90@gmail.com> * Fix a cherry-pick package name issue Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> * Add missing release branch pull requests trigger Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> --------- Signed-off-by: Varun Gupta <varungup90@gmail.com> Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com> Co-authored-by: Varun Gupta <varungup90@gmail.com>
happyandslow
pushed a commit
to happyandslow/aibrix
that referenced
this pull request
Mar 6, 2025
* Ignore worker pods for gateway routing * ignore worker pods in UpdatePod as well * use node worker as const Signed-off-by: Varun Gupta <varungup90@gmail.com> Signed-off-by: Le Xu <le.xu@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Ignores worker pods for gateway routing
Related Issues
Resolves: part of #758
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.