Add framework to setup integration test #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Jan 30, 2025
development/app/app.py
Outdated
| @@ -278,6 +278,7 @@ def completion(): | |||
| return jsonify(err), 500 | |||
|
|
|||
|
|
|||
| @app.route('/chat/completions', methods=['POST']) | |||
There was a problem hiding this comment.
on using openai-go official openai go library uses /chat/completion and v1/chat/completion is used by batch api.
There was a problem hiding this comment.
I feel this is kind of confusing. golang sdk hit different endpoints?
- we are not using batch in testing scenarios
/chat/completionthis is openai not compatible
is there a detail problem on the golang sdk usage?
There was a problem hiding this comment.
There was a problem hiding this comment.
seems they assume v1 as part of the UrlBase. final url is still v1/chat/completions? openai/openai-go#105
If it does need /chat/completions, let document this part in the file.
There was a problem hiding this comment.
added a middleware router to append /v1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.