Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VKE IPv4 Testing Cluster Config #537

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

nwangfw
Copy link
Collaborator

@nwangfw nwangfw commented Dec 17, 2024

Pull Request Description

This PR

  1. Added VKE IPv4 Cluster Config to address the issue that there is no IPv6 in the testing VKE env
  2. Added simulated workload config for testing
  3. Fixed an envoygateway naming issue

Related Issues

Resolves: #534

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw nwangfw requested review from zhangjyr and Jeffwan December 17, 2024 17:55
@nwangfw nwangfw changed the title Add VKE IPv4 Cluster Testing Config Add VKE IPv4 Testing Cluster Config Dec 17, 2024
@@ -1,7 +1,7 @@
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
name: custom-proxy-config
name: aibrix-custom-proxy-config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em. I didn't see namePrefix configuration in your default/kustomization.yaml. can you double check this part? Does other configuration also have prefix aibrix-?

@nwangfw
Copy link
Collaborator Author

nwangfw commented Dec 19, 2024

@Jeffwan Addressed. Please help to review it again when you have a chance. Thanks!

@Jeffwan Jeffwan merged commit 598c37e into main Dec 19, 2024
7 checks passed
@Jeffwan Jeffwan deleted the ning/gpu-optimizer-testing branch December 19, 2024 19:54
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* gpu-optimizer-testing

* remove ipv6 config and add vke-ipv4 config

* update vke overlay ipv4 make command

* update image version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create Gateway Plugins Service on VKE testing
2 participants