Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if no pods are present #345

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add check if no pods are present #345

merged 3 commits into from
Nov 5, 2024

Conversation

varungup90
Copy link
Collaborator

No description provided.

@@ -1,172 +0,0 @@
apiVersion: apps/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varungup90 I see some benchmark/plot changes have been added in the PR. are they expected or rebase issue?

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the related code change looks good to me

@Jeffwan Jeffwan merged commit 89cafe1 into main Nov 5, 2024
9 checks passed
@Jeffwan Jeffwan deleted the add-no-pods-check branch November 5, 2024 02:59
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add check if no pods are present

* nit update

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants