Add container override for images #273
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apiVersion: gateway.envoyproxy.io/v1alpha1 | ||
| kind: EnvoyProxy | ||
| metadata: | ||
| name: custom-proxy-config | ||
| namespace: aibrix-system | ||
| spec: | ||
| provider: | ||
| type: Kubernetes | ||
| kubernetes: | ||
| envoyDeployment: | ||
| container: | ||
| image: aibrix-container-registry-cn-beijing.cr.volces.com/envoyproxy/envoy:distroless-v1.31.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: Gateway | ||
| metadata: | ||
| name: eg | ||
| namespace: aibrix-system | ||
| spec: | ||
| gatewayClassName: aibrix-eg | ||
| infrastructure: | ||
| parametersRef: | ||
| group: gateway.envoyproxy.io | ||
| kind: EnvoyProxy | ||
| name: aibrix-custom-proxy-config |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| resources: | ||
| - ../../../../gateway | ||
| - envoyproxy.yaml | ||
|
|
||
| patches: | ||
| - path: gateway_patch.yaml | ||
|
|
||
|
|
||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| images: | ||
| - name: busybox | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/aibrix/busybox | ||
| newTag: stable | ||
| - name: aibrix/plugins | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/aibrix/plugins | ||
| newTag: nightly | ||
| - name: envoyproxy/envoy | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/envoyproxy/envoy | ||
| newTag: distroless-v1.31.0 | ||
| - name: aibrix/users | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/aibrix/users | ||
| newTag: nightly | ||
| - name: redis | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/aibrix/redis | ||
| newTag: latest | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| namespace: aibrix-system | ||
|
|
||
| namePrefix: aibrix- | ||
|
|
||
| resources: | ||
| - ../../../crd | ||
| - ../../../rbac | ||
| - manager | ||
| - gateway | ||
| - ../../../dependency/kuberay-operator | ||
|
|
||
|
|
||
| images: | ||
| - name: quay.io/kuberay/operator | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/aibrix/quay.io/kuberay/operator | ||
| newTag: v1.2.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| resources: | ||
| - ../../../../manager | ||
|
|
||
| images: | ||
| - name: aibrix/controller-manager | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/aibrix/controller-manager | ||
| newTag: nightly |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: envoy-gateway-config | ||
| namespace: envoy-gateway-system | ||
| data: | ||
| envoy-gateway.yaml: | | ||
| apiVersion: gateway.envoyproxy.io/v1alpha1 | ||
| kind: EnvoyGateway | ||
| provider: | ||
| kubernetes: | ||
| shutdownManager: | ||
| image: aibrix-container-registry-cn-beijing.cr.volces.com/envoyproxy/gateway:v1.1.0 | ||
| type: Kubernetes | ||
| gateway: | ||
| controllerName: gateway.envoyproxy.io/gatewayclass-controller | ||
| extensionApis: | ||
| enableEnvoyPatchPolicy: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| resources: | ||
| - ../../../../dependency | ||
|
|
||
| patches: | ||
| - path: envoy_config_patch.yaml | ||
|
|
||
| images: | ||
| - name: envoyproxy/gateway | ||
| newName: aibrix-container-registry-cn-beijing.cr.volces.com/envoyproxy/gateway | ||
| newTag: v1.1.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| kind: Kustomization | ||
|
There was a problem hiding this comment. if we move image override to this folder. does it mean we just need this single file?
There was a problem hiding this comment. In dependency, envoy-gateway has different namespace. So that will always be separate. In other cases, we can not merge because each one references to their parent also. When I tried to club everything together, resources order is not guaranteed and it was not working. |
||
|
|
||
| resources: | ||
| - envoy-gateway | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious why can not we use envoyproxy + gatreway_patch.yaml from the original folder? If we just like to override the images? I think the one under default/kustomization.yaml is good enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no envoyproxy + gateway_patch in config/gateway. Its a override added to replace envoyproxy image, which was not needed in US env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Makes sense. I misunderstand this part