Use better way to set up controller with Manager #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In traditional flow, any reconciler initialization logic needs to updated in
cmd/main.go
which is not that clean. Now, we borrow the similar way adopted inkruise
. There're few major changesAdd
interface and registry the controller together atpkg/controller/controller.go
and finish setup with managernewReconciler
method in every controller file.After this change, whenever we need add a new controller or update controller initialization logic, we do not need to make the change here
cmd.go
andcontroller.go
, most of the logics will be modified inside it's controller file.