Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch] job FIFO scheduler as baseline #231

Merged
merged 3 commits into from
Sep 27, 2024
Merged

[batch] job FIFO scheduler as baseline #231

merged 3 commits into from
Sep 27, 2024

Conversation

xinchen384
Copy link
Contributor

@xinchen384 xinchen384 commented Sep 25, 2024

Pull Request Description

[Please provide a clear and concise description of your changes here]
This scheduler implementation handles FIFO policy. The main feature are two parts:
(1) Job is scheduled first come first served with queue.
(2) A process is to mark jobs expired by specified due time.

Related Issues

Resolves: part of #182

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 26, 2024

Could you enrich your PR description in future?

  1. talk about the primary change here with some other necessary notes
  2. link back to your issue like [RFC]: Batch API for inference job #182

@Jeffwan Jeffwan merged commit 5e35a16 into main Sep 27, 2024
10 checks passed
@Jeffwan Jeffwan deleted the xin/scheduler branch September 27, 2024 17:32
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* job FIFO scheduler as baseline

* update comments

* func name and typo

---------

Co-authored-by: xin.chen <xin.chen@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants